feat(sec-core): support packaging codex-plugin into rpm#1138
Merged
yangdao479 merged 2 commits intoJun 26, 2026
Conversation
yangdao479
requested changes
Jun 25, 2026
yangdao479
left a comment
Collaborator
There was a problem hiding this comment.
- 需要在srcipts/rpm-build.sh增加tar的打包内容,否则codex-hook不在rpm的source tarball内
- codex-hook目前只支持了rpm的安装,缺少源码安装的支持(build from scartch), 这个可以在follow-up的pr中补齐
yangdao479
reviewed
Jun 25, 2026
Collaborator
|
需要同步更新rpm-build的ci,至少验证codex的相关代码文件在rpm安装后存在 |
yangdao479
reviewed
Jun 25, 2026
2994063 to
7679bbe
Compare
8bc4221 to
5951911
Compare
yangdao479
requested changes
Jun 25, 2026
yangdao479
reviewed
Jun 25, 2026
Collaborator
|
[NIT]: openclaw / hermes的plugin安装脚本路径都在 scripts/deploy.sh。 而codex的plugin安装脚本为install.sh。 这里存在不一致性,可能让使用者confuse,不阻塞本次PR、待后续改进。 |
edonyzpc
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Follow-up to #1074. That PR added the codex-plugin source code; this PR extends the sec-core packaging configuration so codex-plugin is shipped in the RPM.
Changes
src/agent-sec-core/Makefile: add codex-plugin install targetsrc/agent-sec-core/agent-sec-core.spec.in: include codex-plugin files in the manifestStatus
Draft. Will attach the
sec-core-rpmbuildworkflow run link and RPM artifact once the build succeeds on the fork./cc @yangdao479