Skip to content

feat(sec-core): support packaging codex-plugin into rpm#1138

Merged
yangdao479 merged 2 commits into
alibaba:mainfrom
moli0118:feature/sec-core/codex-plugin-rpm
Jun 26, 2026
Merged

feat(sec-core): support packaging codex-plugin into rpm#1138
yangdao479 merged 2 commits into
alibaba:mainfrom
moli0118:feature/sec-core/codex-plugin-rpm

Conversation

@moli0118

Copy link
Copy Markdown
Contributor

Background

Follow-up to #1074. That PR added the codex-plugin source code; this PR extends the sec-core packaging configuration so codex-plugin is shipped in the RPM.

Changes

  • src/agent-sec-core/Makefile: add codex-plugin install target
  • src/agent-sec-core/agent-sec-core.spec.in: include codex-plugin files in the manifest

Status

Draft. Will attach the sec-core-rpmbuild workflow run link and RPM artifact once the build succeeds on the fork.

/cc @yangdao479

@github-actions github-actions Bot added the component:sec-core src/agent-sec-core/ label Jun 25, 2026

@yangdao479 yangdao479 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 需要在srcipts/rpm-build.sh增加tar的打包内容,否则codex-hook不在rpm的source tarball内
  2. codex-hook目前只支持了rpm的安装,缺少源码安装的支持(build from scartch), 这个可以在follow-up的pr中补齐

Comment thread src/agent-sec-core/agent-sec-core.spec.in
Comment thread src/agent-sec-core/Makefile Outdated
Comment thread src/agent-sec-core/Makefile
Comment thread src/agent-sec-core/Makefile
Comment thread src/agent-sec-core/Makefile Outdated
Comment thread src/agent-sec-core/Makefile
Comment thread src/agent-sec-core/agent-sec-core.spec.in Outdated
@yangdao479

Copy link
Copy Markdown
Collaborator

需要同步更新rpm-build的ci,至少验证codex的相关代码文件在rpm安装后存在

@yangdao479 yangdao479 marked this pull request as ready for review June 25, 2026 12:01
Comment thread scripts/rpm-build.sh Outdated
@moli0118 moli0118 force-pushed the feature/sec-core/codex-plugin-rpm branch from 2994063 to 7679bbe Compare June 25, 2026 12:53
@moli0118 moli0118 force-pushed the feature/sec-core/codex-plugin-rpm branch from 8bc4221 to 5951911 Compare June 25, 2026 13:44
Comment thread scripts/rpm-build.sh Outdated
Comment thread src/agent-sec-core/Makefile
Comment thread src/agent-sec-core/agent-sec-core.spec.in
@yangdao479

yangdao479 commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

[NIT]: openclaw / hermes的plugin安装脚本路径都在 scripts/deploy.sh。 而codex的plugin安装脚本为install.sh。 这里存在不一致性,可能让使用者confuse,不阻塞本次PR、待后续改进。

@yangdao479 yangdao479 requested a review from edonyzpc June 25, 2026 14:18

@edonyzpc edonyzpc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangdao479 yangdao479 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangdao479 yangdao479 merged commit 9bd5365 into alibaba:main Jun 26, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:sec-core src/agent-sec-core/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants