feat(blaze): maintain automatic warm capacity - #2285
Conversation
|
@codex review Please review exact head |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
WeissonHan
changed the title
4ab00f8 to
49d9441
Compare
|
@codex review Please review exact head |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
49d9441 to
1c99a7b
Compare
|
@codex review This PR adds an optional storage-provider inventory for complete and partial owned slots, with strict file-provider classification and idempotent release by stable ID. Please review the complete pull request: every commit, the cumulative diff against the base branch, and the implementation, tests, and documentation as one submitted change. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c99a7b558
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1c99a7b to
84e4521
Compare
|
@codex review This PR adds an optional storage-provider inventory for complete and partial owned slots, with strict file-provider classification, retryable release by stable ID, and matching English and Chinese protocol documentation. Please review the complete pull request: every commit, the cumulative diff against the base branch, and the implementation, tests, and documentation as one submitted change. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
![qoderai[bot]](https://avatars.githubusercontent.com/in/1396158?s=60&v=4){kind=small}
84e4521 to
9a96680
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This enables `StorageProvider` callers to enumerate complete and partially created slots under the configured root and release them by stable ID through an optional provider contract. Previously, release by ID could clean up a known slot, but no provider-neutral inventory exposed residual directories. The file provider now validates every direct entry, returns IDs in stable order, and refuses linked, non-directory, invalid, or unrepresentable entries instead of silently skipping them. The inventory is point-in-time, so a future caller that needs a stable boundary must serialize it with acquire and release operations. This is a provider foundation; no daemon consumer or restart reconciliation policy is wired here. Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com> Signed-off-by: Weisson Han <wenshu.hx@linux.alibaba.com>
|
@codex review |
9a96680 to
afde1cd
Compare
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review This PR adds an internal storage capability for discovering and cleaning The earlier reader-facing design-document additions have been removed because |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
This PR has been returned to Draft while it is reorganized around its first production caller. The current head provides the internal storage inventory contract and file-backed implementation, but it does not yet change daemon behavior. The same foundation will remain as the first commit of a cohesive automatic warm-runtime feature. Later commits in this PR will directly consume it for bounded background preparation, compatible create-time claims, restart reconciliation, and cleanup. This avoids merging an internal contract without a live caller. The branch will be rebased onto the current Dependency: #2113 |
WeissonHan
changed the title
1 participant
Description
This draft will deliver bounded automatic warm capacity through the existing
sandbox create path.
The completed pull request will:
storage.pool_sizeis positive;storage.prefork = true;POST /v1/sandboxesrequest claim one ready slot;cancellation, and bounded shutdown; and
No management route or internal ownership field is added to the HTTP API.
The four existing
/v1/poolscompatibility routes remain unsupported.Draft status: the current public head is still the one-commit
provider-owned slot-inventory foundation
(
afde1cd0e21759b110e390ecc55c285b760683bd). It has no daemon productioncaller and does not implement automatic warm capacity. Checks and reviews
attached to this head validate only that foundation.
A separate integration-only reconstruction reorganizes the earlier five-commit
development layout into four feature commits: durable cleanup authority;
automatic storage capacity with the provider inventory folded into its first
production consumer; backend preforking; and documentation. This reconstruction
is not the public pull-request head, is not a merge candidate, and cannot make
this pull request Ready while #2290 and #2471 remain open.
The corrected four-commit integration-only reconstruction has now completed
its private per-commit Linux validation matrix. The dependency correction was
limited to stale test-only interfaces; source and tree reconciliation confirmed
that the intended feature and documentation content were unchanged. These
results do not attach to the current public head and do not establish a merge
candidate. Any change to
main, #2290, or #2471 makes this matrix historicalevidence.
For the complete feature, documentation will update the existing English and
Chinese component READMEs and runtime user guides, the annotated example
configuration, and the existing bilingual lifecycle-consistency and
storage-artifact-synchronization design documents. It will add no new design
document or changelog entry.
Related Issue
Closes #2460
Refs #2284
Type of Change
to stop working as expected)
Scope
blaze(blaze)Checklist
package-lock.json/Cargo.lock)Testing
The current public foundation-only head has the following public results:
CI / Componentsrun 31576556947succeeded.
CI / PR Lintrun 31886788609succeeded, superseding the earlier checkout-only failure; the subsequent
body-update run 31932348141
also succeeded.
license/cla: successfor this public head.found no major issues at
afde1cd0e21759b110e390ecc55c285b760683bd.These results validate only the provider-inventory foundation. They do not
validate automatic warm capacity.
The corrected integration-only reconstruction completed a fresh native Linux
x86_64 matrix with Rust and Cargo 1.88, locked and offline dependencies, and
fresh source and build directories at every commit boundary. Its
integration-only dependency base passed both default and all-feature builds.
Each of the four feature commits passed formatting; locked and offline metadata;
default and all-feature workspace builds for all targets; strict default and
all-feature Clippy; serial default and all-feature workspace tests; strict
default and all-feature rustdoc; focused tests; and source and tree
reconciliation.
The documentation commit also passed bilingual documentation lint and link
checks. Its documentation content and the intended feature trees were unchanged
by the dependency-only test correction. Every recorded command completed
normally; no result depends on a skipped command or an infrastructure failure.
This is private integration evidence only. It is not attached to the public
head and is not a merge candidate. Any change to
main, #2290, or #2471 makesthis matrix historical evidence.
Before this draft can become ready, the published final head and its
current-main merge candidate must repeat the complete Linux contract, including
a real daemon smoke test for storage-only and preforked capacity.
Dependencies
The startup inventory prerequisite from #2113 is already in
main.The complete feature depends on:
races.
The unpublished integration-only reconstruction used these exact historical
inputs:
mainatba20d94d19a73e5b781cab0c687d4034ad0d0dae;adbe1c1220b426e3340877c0599f31d9c2f4237c; and03616fc0a18d06ec5d170df344e2dc2465e1ec10.Both dependency pull requests remain open. This Draft must not be merged or
marked Ready on the strength of that integration-only reconstruction.
After both dependencies merge, the four feature commits must be reconstructed
on the then-current exact
main. The new public head and its newly generatedmerge candidate must repeat the complete exact-head Linux validation, all
GitHub-hosted workflows, the public CLA status, and a fresh exact-head Codex
review before this Draft can be marked Ready.