fix(skill): add missing Provides: anolisa-component(os-skills) to RPM spec - #2567
Open
zhangtaibo wants to merge 1 commit into
Open
fix(skill): add missing Provides: anolisa-component(os-skills) to RPM spec#2567zhangtaibo wants to merge 1 commit into
zhangtaibo wants to merge 1 commit into
Conversation
… spec The os-skills RPM spec was missing the 'Provides: anolisa-component(os-skills)' virtual provide line that agentsight, copilot-shell, cosh-ng, and skillfs already declare. When the repo-side components-v2.toml is unavailable (HTTP 404) and no package_map entry exists in repo.toml, the ANOLISA RPM resolver falls through all three resolution paths and returns empty candidates, causing 'INVALID_ARGUMENT: not an ANOLISA RPM component'. Fixes #2559 (same root cause, covers os-skills). Complements PR #2560 (agent-memory) and PR #2563 (agent-sec-core). Verified on ECS: with this patch, rpm-build.sh produces RPMs that include the anolisa-component(os-skills) provides, and 'anolisa install os-skills --dry-run' returns ok=true with dry_run=true and a plan. 'anolisa adapter scan' correctly lists the os-skills component adapters after install+adopt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The os-skills RPM spec was missing the
Provides: anolisa-component(os-skills)virtual provide line that agentsight, copilot-shell, cosh-ng, and skillfs already declare.When the repo-side components-v2.toml is unavailable (HTTP 404) and no package_map entry exists in repo.toml, the ANOLISA RPM resolver falls through all three resolution paths (package_map → component_index → rpm_package_provides_component) and returns empty candidates, causing
INVALID_ARGUMENT: not an ANOLISA RPM component.Root Cause
Commit cdd665f (Jun 26, feat(skill): add anolisa component contract) added component.toml installation to the spec but forgot to add the
Provides: anolisa-component(os-skills)line.Compare with other specs that already have it:
Fix
Add the missing
Provides: anolisa-component(os-skills)line with an explanatory comment block, matching the pattern used by PR #2560 (agent-memory) and PR #2563 (agent-sec-core).Verification
Verified on ECS 8.217.123.80:
bash scripts/rpm-build.sh os-skills→ RPM built successfullyrpm -q --provideson built RPM includesanolisa-component(os-skills)anolisa install os-skills --backend rpm --package os-skills --dry-run→ok=true, dry_run=true, plan=[dnf install,observe,record]anolisa adopt os-skills→ok=true, adoptedanolisa adapter scan→ lists os-skills adapters (openclaw + hermes, resource_present=true, driver_available=true)Fixes #2559 (same root cause, covers os-skills).
Complements PR #2560 (agent-memory) and PR #2563 (agent-sec-core).