Skip to content

fix(skill): add missing Provides: anolisa-component(os-skills) to RPM spec - #2567

Open
zhangtaibo wants to merge 1 commit into
mainfrom
fix/os-skills-missing-provides
Open

fix(skill): add missing Provides: anolisa-component(os-skills) to RPM spec#2567
zhangtaibo wants to merge 1 commit into
mainfrom
fix/os-skills-missing-provides

Conversation

@zhangtaibo

Copy link
Copy Markdown
Collaborator

Summary

The os-skills RPM spec was missing the Provides: anolisa-component(os-skills) virtual provide line that agentsight, copilot-shell, cosh-ng, and skillfs already declare.

When the repo-side components-v2.toml is unavailable (HTTP 404) and no package_map entry exists in repo.toml, the ANOLISA RPM resolver falls through all three resolution paths (package_map → component_index → rpm_package_provides_component) and returns empty candidates, causing INVALID_ARGUMENT: not an ANOLISA RPM component.

Root Cause

Commit cdd665f (Jun 26, feat(skill): add anolisa component contract) added component.toml installation to the spec but forgot to add the Provides: anolisa-component(os-skills) line.

Compare with other specs that already have it:

  • agentsight.spec.in:20
  • skillfs.spec.in:26
  • copilot-shell.spec.in:18
  • cosh-ng.spec.in:21

Fix

Add the missing Provides: anolisa-component(os-skills) line with an explanatory comment block, matching the pattern used by PR #2560 (agent-memory) and PR #2563 (agent-sec-core).

Verification

Verified on ECS 8.217.123.80:

  1. bash scripts/rpm-build.sh os-skills → RPM built successfully
  2. rpm -q --provides on built RPM includes anolisa-component(os-skills)
  3. anolisa install os-skills --backend rpm --package os-skills --dry-runok=true, dry_run=true, plan=[dnf install,observe,record]
  4. anolisa adopt os-skillsok=true, adopted
  5. anolisa adapter scan → lists os-skills adapters (openclaw + hermes, resource_present=true, driver_available=true)

Fixes #2559 (same root cause, covers os-skills).
Complements PR #2560 (agent-memory) and PR #2563 (agent-sec-core).

… spec

The os-skills RPM spec was missing the 'Provides: anolisa-component(os-skills)'
virtual provide line that agentsight, copilot-shell, cosh-ng, and skillfs
already declare. When the repo-side components-v2.toml is unavailable
(HTTP 404) and no package_map entry exists in repo.toml, the ANOLISA RPM
resolver falls through all three resolution paths and returns empty
candidates, causing 'INVALID_ARGUMENT: not an ANOLISA RPM component'.

Fixes #2559 (same root cause, covers os-skills).
Complements PR #2560 (agent-memory) and PR #2563 (agent-sec-core).

Verified on ECS: with this patch, rpm-build.sh produces RPMs that include
the anolisa-component(os-skills) provides, and 'anolisa install os-skills
--dry-run' returns ok=true with dry_run=true and a plan. 'anolisa adapter
scan' correctly lists the os-skills component adapters after install+adopt.
@zhangtaibo
zhangtaibo requested a review from Ziqi002 as a code owner August 14, 2026 12:46
@github-actions github-actions Bot added the component:skill src/os-skills/ label Aug 14, 2026

@qoderai qoderai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本次审查范围内未发现需要修改的问题。


🤖 Generated by QoderView workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:skill src/os-skills/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Nightly][anolisa] bug: agent-memory RPM spec missing Provides: anolisa-component(agent-memory), causing install INVALID_ARGUMENT and adapter scan empty

1 participant