-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add annotation for mirror svc #1121
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看看加下e2e test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question for this feature, how do we specify the mirror filter to a specific rule? Or does it mean all rules backend will have a same mirror svc?
@robynron 解决一下冲突吧 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1121 +/- ##
==========================================
+ Coverage 35.91% 44.12% +8.21%
==========================================
Files 69 76 +7
Lines 11576 9895 -1681
==========================================
+ Hits 4157 4366 +209
+ Misses 7104 5192 -1912
- Partials 315 337 +22
|
mirror all rules under an ingress to new services by percentage. |
Ⅰ. Describe what this PR did
add new ingress annotation feature.
higress.io/mirror-target-service
: Route traffic that meets all routing rules under the ingress to the specified service.higress.io/mirror-percentage
: Route traffic that meets all routing rules under the ingress to the specified services by percentage.Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews