feat: create podmonitor cr in helm chart #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fengxsong
force-pushed
the
feat_podmonitor
branch
from
5571310
to
3aaf18f
Compare
|
@fengxsong Please resolve the conflicts |
Signed-off-by: fengxusong <[email protected]>
Signed-off-by: fengxusong <[email protected]>
fengxsong
force-pushed
the
feat_podmonitor
branch
from
3aaf18f
to
0da389a
Compare
|
@johnlanni PTAL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1157 +/- ##
==========================================
+ Coverage 35.91% 44.31% +8.40%
==========================================
Files 69 75 +6
Lines 11576 9823 -1753
==========================================
+ Hits 4157 4353 +196
+ Misses 7104 5142 -1962
- Partials 315 328 +13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
gateway.podTemplateto rendering pod template spec, so we can keep daemonset.yaml and deployment.yaml DRYpodmonitor/vmpodscrapecustomresource for monitoring purposeⅡ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
try
helm template --set gateway.metrics.enabled=true xxxx helm/core/to verify.Ⅴ. Special notes for reviews