fix: Wasm-rust plugin crashed when header name or value is not a valid UTF8 string #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
ok 已添加 |
|
上面的 CLA 麻烦签署一下。 @jaymie9019 |
有点尴尬，我一开始用了我公司的云效账号的 git 账号和邮箱，后来我发现了，第二次提交改了本地仓库的用户和邮箱。 xiaoma 这个用户并没有 github 账号。 需要把整个分支删除，然后重新提交一次代码吗 |
commit 信息可以改的，你rebase一下或者reset一下之后force push |
jaymie9019
force-pushed
the
fix/wasm-rust-panic
branch
2 times, most recently
from
6054f95
to
a041f64
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1295 +/- ##
==========================================
+ Coverage 35.91% 44.31% +8.40%
==========================================
Files 69 75 +6
Lines 11576 9823 -1753
==========================================
+ Hits 4157 4353 +196
+ Misses 7104 5142 -1962
- Partials 315 328 +13 |
|
|
优化 PluginHttpWrapper req_header 与 resp_header 的获取方方式，避免因为不规范的 http header 导致 plugin panic，并且打印不规范的 header 日志
007gzs
force-pushed
the
fix/wasm-rust-panic
branch
from
eb88b82
to
4b3a28a
Compare
007gzs
changed the title
thanks~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
优化 wasm rust sdk 中 PluginHttpWrapper req_header 获取方方式，避免因为不规范的 http header 导致 plugin panic，并且打印不规范的 header 日志。已在生产环境验证
Ⅱ. Does this pull request fix one issue?
fixes #1280
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews