Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support status sync for Gateway API resources #1315

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hanxiantao
Copy link
Collaborator

@hanxiantao hanxiantao commented Sep 15, 2024

Ⅰ. Describe what this PR did

feat: Support status sync for Gateway API resources

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 54.23729% with 27 lines in your changes missing coverage. Please review.

Project coverage is 43.75%. Comparing base (ef31e09) to head (d555f72).
Report is 101 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ingress/kube/gateway/istio/context.go 55.76% 15 Missing and 8 partials ⚠️
pkg/ingress/kube/gateway/controller.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1315      +/-   ##
==========================================
+ Coverage   35.91%   43.75%   +7.84%     
==========================================
  Files          69       75       +6     
  Lines       11576     9849    -1727     
==========================================
+ Hits         4157     4309     +152     
+ Misses       7104     5199    -1905     
- Partials      315      341      +26     
Files with missing lines Coverage Δ
pkg/ingress/kube/gateway/istio/controller.go 59.67% <100.00%> (ø)
pkg/ingress/kube/gateway/controller.go 49.47% <33.33%> (ø)
pkg/ingress/kube/gateway/istio/context.go 60.49% <55.76%> (ø)

... and 87 files with indirect coverage changes

@hanxiantao
Copy link
Collaborator Author

hanxiantao commented Sep 15, 2024

当前进度:

  • 已实现Kubernetes Service的状态同步功能

待解决问题:

  • 修复conversion_test.go中的三个单元测试问题
  • pkg/ingress/kube/gateway/istio/context.go中的GetService()方法需支持ServiceEntry查询

待确认问题:

@johnlanni
Copy link
Collaborator

@hanxiantao 支持 serviceEntry parent 是 Service Mesh 场景,higress这侧不需要实现

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants