feat: add request size limit plugin #528
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
johnlanni
reviewed
Sep 22, 2023
| return nil | ||
| } | ||
|
|
||
| func onHttpRequestBody(ctx wrapper.HttpContext, config RequestSizeLimitConfig, body []byte, log wrapper.Log) types.Action { |
There was a problem hiding this comment.
这样实现是有问题的，这里只能拿到第一段body的length，要实现这个功能需要sdk支持流式处理body，这个还需要改进下才能支持，我先把PR标记为draft了
There was a problem hiding this comment.
这样实现是有问题的，这里只能拿到第一段body的length，要实现这个功能需要sdk支持流式处理body，这个还需要改进下才能支持，我先把PR标记为draft了
了解了，sdk支持流式处理body目前有排期计划支持吗？
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
add request size limit plugin
Ⅱ. Does this pull request fix one issue?
#392
Ⅲ. Why don't you add test cases (unit test/integration test)?
this is a wasm plugin.
Ⅳ. Describe how to verify it
Use the plugin with
READMEin the plugin directory.Ⅴ. Special notes for reviews