feat(useFavicon): Allow additional dependency list for useFavicon()
hook
#2743
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, ahooks team!
First of all, thanks for maintaining this project.
🤔 This is a ...
💡 Background and solution
I have encountered several cases where the favicon doesn't update when the source URL changes. This pull request addresses that issue by allowing an additional
deps?: React.DependencyList
argument for theuseFavicon()
hook. This enhancement ensures that the favicon updates properly when the dependencies change.📝 Changelog
deps?: React.DependencyList
argument for theuseFavicon()
hook.☑️ Self Check before Merge
I appreciate your feedback in advance.