Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useFavicon): Allow additional dependency list for useFavicon() hook #2743

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rapsealk
Copy link

Hello, ahooks team!

First of all, thanks for maintaining this project.

🤔 This is a ...

  • New feature

💡 Background and solution

I have encountered several cases where the favicon doesn't update when the source URL changes. This pull request addresses that issue by allowing an additional deps?: React.DependencyList argument for the useFavicon() hook. This enhancement ensures that the favicon updates properly when the dependencies change.

📝 Changelog

Language Changelog
🇺🇸 English Allow additional deps?: React.DependencyList argument for the useFavicon() hook.
🇨🇳 Chinese 允许为 useFavicon() hook 添加额外的 deps?: React.DependencyList 参数。(Translated by ChatGPT)

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Changelog is provided or not needed

I appreciate your feedback in advance.

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants