feat: gomysql instrumentation support - #685
Open
josealdaco wants to merge 6 commits into
Open
Conversation
Collaborator
|
@claude rebase main |
Collaborator
|
@copilot resolve the merge conflicts in this pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for instrumenting the
go-mysqllibrary with OpenTelemetry in the Loongsuite Go agent. It introduces a new instrumentation module forgo-mysql, updates the semantic conventions and registry, and adds comprehensive tests for the new functionality. Additionally, it improves the extraction of database connection attributes and updates documentation to reflect the new support.Go-MySQL Instrumentation Support
go-mysql(pkg/rules/go-mysql), including the main instrumenter logic (gomysql_otel_instrumenter.go) and runtime hooks (setup.go), enabling automatic tracing of MySQL client operations. [1] [2]go-mysqlinstrumentation with required dependencies inpkg/rules/go-mysql/go.mod.Database Attribute Extraction Enhancements
db.connectionId) for SQL clients, improving traceability of database connections. [1] [2]Testing and Verification
go-mysqlintest/go_mysql_tests.goand accompanying test application code intest/gomysql/test_conn.go, ensuring the new instrumentation works as expected. [1] [2]test/gomysql/go.mod.Documentation Updates
README.mdto addgo-mysqlto the list of supported libraries and made minor formatting corrections. [1] [2] [3]