fix(deploy): avoid SIGPIPE when previewing package contents - #53
Merged
Merged
Conversation
ralf0131
approved these changes
Jun 22, 2026
ralf0131
left a comment
ralf0131
left a comment
Collaborator
There was a problem hiding this comment.
Good fix. Replacing head -20 with sed -n '1,20p' avoids the SIGPIPE that head triggers by closing its stdin early — under set -o pipefail tar would exit non-zero (141) and abort the script. sed -n drains the full stream so tar completes cleanly. LGTM.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script deploy/package-opensource.sh enables strict mode via set -euo pipefail.
At the end of the script, the command tar -tzf "$OUTPUT_PATH" | head -20 is executed.
In Linux environments, head -20 closes the pipe immediately after printing the first 20 lines. This sends a SIGPIPE signal to the upstream tar process, making tar exit with code 141.
Due to set -o pipefail, the entire pipeline returns a non-zero exit code, which triggers set -e to terminate the whole script and results in the build failure.