Skip to content

Add Trustabl Agent Scanner to CI #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshua-trustabl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Trustabl Agent Scanner to CI #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/trustabl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: Trustabl
on:
push:
branches: [main]
pull_request:

permissions:
contents: read
security-events: write
pull-requests: write

@ralf0131 ralf0131 Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overly broad permissions. The workflow grants pull-requests: write and security-events: write, but a read-only scanner typically only needs contents: read. Consider applying the principle of least privilege and removing unnecessary write permissions. If the action does need to post findings as PR comments, document why in the PR description.


@ralf0131 ralf0131 Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Permissions] pull-requests: write is broader than needed for a read-only scanner. If the action only posts SARIF results, security-events: write suffices. If it posts PR comments, this is justified but worth documenting why.

jobs:
scan:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

@ralf0131 ralf0131 Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security: Action not pinned to commit SHA. trustabl/trustabl-action@v0 uses a mutable tag reference. GitHub Actions security best practice requires pinning third-party actions to a full commit SHA (e.g., trustabl/trustabl-action@<40-char-sha>) to prevent supply chain attacks via tag mutation. See GitHub Security Hardening.

@ralf0131 ralf0131 Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Security] Using a floating tag trustabl/trustabl-action@v0 is a supply-chain risk — tags can be moved to point to different commits. Consider pinning to a specific commit SHA for reproducibility.

@ralf0131 ralf0131 Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Security] Third-party action pinned to mutable tag @v0. Best practice is to pin to a full commit SHA to prevent supply-chain attacks (the tag can be force-pushed to a different commit). Consider using - uses: trustabl/trustabl-action@<commit-sha> instead. Additionally, v0 indicates pre-1.0 — breaking changes may occur without notice.

- uses: trustabl/trustabl-action@v0