Skip to content

chore(pages): remove MacPorts install channel - #1334

Merged
lizhengfeng101 merged 1 commit into
mainfrom
remove-macports-install
Sep 17, 2026
Merged

lizhengfeng101 merged 1 commit into
mainfrom
remove-macports-install

Conversation

@lizhengfeng101

Copy link
Copy Markdown
Contributor

What

Remove the MacPorts installation method from the marketing site (pages/) and the documentation site.

  • Landing page (HeroSection.tsx): drop the macports entry and its icon import from INSTALL_CHANNELS.
  • Icon: delete pages/src/assets/icons/macports.svg.
  • i18n: remove the hero.installMacPorts label from all five locale tables (en / zh / ja / ko / ru).
  • Docs: remove the ## MacPorts section from every installation.md and adjust the install-method count from six to five.
  • Tests: switch the overflow-channel test in HeroSection.test.tsx from MacPorts to the Windows channel.

Why

MacPorts is no longer a recommended way to install ocr, so it should not be surfaced as an install option on the site or in the docs.

Verification

  • HeroSection component tests pass (6/6).
  • tsc --noEmit and ESLint report no new errors.
  • Grep confirms no remaining MacPorts / port install references under pages/.

AI/LLM disclosure

Model used: Claude Opus 4.8. The diff was additionally reviewed with ocr review (open-code-review), which reported no findings.

Drop the MacPorts option from the landing page install switcher and
the documentation site, since it is no longer a recommended way to
install ocr.

- Remove the macports entry and icon import from INSTALL_CHANNELS
- Delete the macports.svg icon and the hero.installMacPorts label
  from all five locale tables
- Remove the MacPorts section from every installation.md and adjust
  the install-method count from six to five
- Switch the overflow-channel test to the Windows channel
@github-actions

Copy link
Copy Markdown
Contributor

OpenCodeReview: Review complete: 0 finding(s) across 6 selected item(s).

@wu21-web wu21-web left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I told this to the port maintainer and oytech will take over the port.

@MuoDoo MuoDoo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhengfeng101
lizhengfeng101 merged commit 0b17f2e into main Sep 17, 2026
28 of 29 checks passed
@lizhengfeng101
lizhengfeng101 deleted the remove-macports-install branch September 17, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants