Skip to content

fix: Fix undefined behavior in BinarySection bitmask constants caused by signed left shift #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lxy-9602 merged 1 commit into from
May 26, 2026
Merged

fix: Fix undefined behavior in BinarySection bitmask constants caused by signed left shift #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/paimon/common/data/binary_section.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@ class PAIMON_EXPORT BinarySection {
/// This is used to decide whether the data is stored in fixed-length part or
/// variable-length part. see `MAX_FIX_PART_DATA_SIZE` for more information.

static constexpr int64_t HIGHEST_FIRST_BIT = 0x80L << 56;
static constexpr int64_t HIGHEST_FIRST_BIT = static_cast<int64_t>(0x80ULL << 56);
/// To get the 7 bits length in second bit to eighth bit out of a int64_t. Form:
/// 01111111 00000000... (8 bytes)
/// This is used to get the length of the data which is stored in this int64_t. see
/// `MAX_FIX_PART_DATA_SIZE` for more information.

static constexpr int64_t HIGHEST_SECOND_TO_EIGHTH_BIT = 0x7FL << 56;
static constexpr int64_t HIGHEST_SECOND_TO_EIGHTH_BIT = static_cast<int64_t>(0x7FULL << 56);

/// Get binary, if len less than 8, will be include in variable_part_offset_and_len.
/// @note Need to consider the ByteOrder.
Expand Down
Loading