feat: remove support for FLOAT/DOUBLE type partition field#333
Open
lszskye wants to merge 3 commits into
Open
Conversation
zjw1111
requested changes
Jun 3, 2026
Collaborator
zjw1111
left a comment
There was a problem hiding this comment.
Requesting changes for one scope issue:
src/paimon/testing/utils/data_generator.cpp: removingFLOAT/DOUBLEsupport fromDataGenerator::WriteBinaryRowalso affects bucket-row construction, not only partition-row construction.SplitArrayByPartitionAndBucket()uses the sameExtractPartialRow(binary_row, bucket_fields)path to buildbucket_rowfor bucket id calculation. The schema validation added in this PR only rejectsFLOAT/DOUBLEpartition keys, whileFLOAT/DOUBLEbucket keys are still allowed and the productionBucketIdCalculator::WriteBucketRowstill supports them. As a result, a legal table with aFLOAT/DOUBLEbucket key that is not a partition key can become unsupported in the test data generation path. Please keep theFLOAT/DOUBLEbranches inDataGenerator::WriteBinaryRow, or split the helper so the new restriction applies only to the partition converter / schema validation path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
remove support for FLOAT/DOUBLE type partition field