[sfmData] ImageInfo: Add support for ARRI- and DJI-specific focal length metadata #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servantftechnicolor
approved these changes
Oct 16, 2024
| } | ||
|
|
||
| // Focal length is provided in µm, hence the required division | ||
| focalLength = std::stod(focalLengthStr) / std::stod(focalLengthDividerStr); |
There was a problem hiding this comment.
std::stod is throwing, maybe you should catch error ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the support for the detection of the focal length from the metadata of some ARRI cameras and DJI drones.
For DJI drones, the metadata is provided in the
focal_lengthentry as a "[xxx,yyy]" string, with "xxx" the focal length and "yyy" the factor to divide it with so that it is in millimeters.For ARRI cameras, the 'axialNominalFocalLength` entry was already detected, but assumed the focal length to already be in millimeters. It can actually also be provided in µm, meaning that it will need a conversion. To distinguish both cases, we check whether the focal length is larger than 9999 and if so, apply the conversion from µm to mm.