[sfm] New sfmFilter software: split sfm based on filenames regex #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create new sfmdatas by selecting views from sfmData with regex.
fcastan
force-pushed
the
dev/sfmFilter
branch
from
ac4bb57
to
70a3c78
Compare
fabiencastan
changed the title
cbentejac
reviewed
Oct 29, 2024
|
|
||
| CmdLine cmdline("AliceVision sfmFilter"); | ||
| cmdline.add(requiredParams); | ||
| //cmdline.add(optionalParams); |
There was a problem hiding this comment.
Unused line, to be removed.
| "Path to the output SfMData file.\n") | ||
| ("outputSfMData_unselected,o", po::value<std::string>(&outputSfMFilenameUnselected)->required(), | ||
| "Path to the output SfMData file.\n"); | ||
|
|
There was a problem hiding this comment.
Suggested change
| // clang-format on | |
clang-format is disabled at the beginning of the parameters listing but it is never re-enabled. It should be re-enabled as soon as the parameters have been described.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SfMFilter can be used to create a new sfmdata containing a subset of views, selected using a regex on their name.
SfMTransfert can now select view using their poseID (used in MV-PS)