Non monotonic HDR bracketing pattern support #1832
Open
+199
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (int idref = 1; idref < monotonics.size(); ++idref) | ||
| // In some cases (some Nikon cameras for instance) the medium exposure is at the first position of the ldr images group. | ||
| // Check that case and try to insert the resulting luminanceInfos seen as outliers at the mid index in the correponding groups. | ||
| if ((luminanceInfos.size() - monotonics.size() * monotonics[0].size() >= monotonics.size()) && // at least as many remaining outliers as groups |
There was a problem hiding this comment.
monotonics[0].size() <--> bestBracketCount ?
There was a problem hiding this comment.
same think because above in the code, all groups with different size from bestBracketCount are removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at supporting a specific pattern of LDR images when building a HDR image. The pattern is given by the set of image exposures when the LDR image set is sorted according to the alphabetic order.
Up to now, only monotonic patterns was supported. However, it appears that in some cases the middle exposure is delivered at the first position, followed by the darker images in the increasing order and by the brighter images also in the increasing order. For a set of 7 LDR images here is this pattern's exposures: 0, -3, -2, -1, 1, 2, 3. Currently, the HDR image is built without using the reference exposure which appears at the first position, focusing only on the monotonic part of the image set and considering the middle exposition as an outlier.
A check for a non coherent case has been added to detect that the total number of LDR images used for building the HDR images is not higher than the original number of LDR images.
Features list
Implementation remarks