Skip to content

Add default value to Price and Weight adjuster. #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add default value to Price and Weight adjuster. #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BigCommerce/ResourceModels/Catalog/Product/PriceAdjuster.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ class PriceAdjuster extends ResourceModel
public const ADJUSTER_RELATIVE = 'relative';
public const ADJUSTER_FIXED = 'fixed';

public string $adjuster;
public string $adjuster = self::ADJUSTER_FIXED;
public float $adjuster_value;
}
5 changes: 4 additions & 1 deletion src/BigCommerce/ResourceModels/Catalog/Product/WeightAdjuster.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@

class WeightAdjuster extends ResourceModel
{
public string $adjuster;
public const ADJUSTER_RELATIVE = 'relative';
public const ADJUSTER_FIXED = 'fixed';

public string $adjuster = self::ADJUSTER_FIXED;
public float $adjuster_value;
}
22 changes: 22 additions & 0 deletions tests/BigCommerce/Api/Catalog/Products/ProductModifier/ProductModifierValuesApiTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

namespace BigCommerce\Tests\Api\Catalog\Products\ProductModifier;

use BigCommerce\ApiV3\ResourceModels\Catalog\Product\PriceAdjuster;
use BigCommerce\ApiV3\ResourceModels\Catalog\Product\ProductModifier;
use BigCommerce\ApiV3\ResourceModels\Catalog\Product\ProductModifierValueData;
use BigCommerce\Tests\BigCommerceApiTest;

Expand Down Expand Up @@ -68,4 +70,24 @@ public function testCanUpdateModifierValue()

$this->assertJsonStringEqualsJsonString($expectedJson, json_encode($modifierValue));
}

public function testCanSetDefaultAdjusterType()
{
$adjuster = new PriceAdjuster();
$this->assertEquals(PriceAdjuster::ADJUSTER_FIXED, $adjuster->adjuster);

$this->setReturnData('catalog__products__modifiers__222__values__190__get.json');

$modifierValue = $this->getApi()
->catalog()->product(1)->modifier(222)->value(190)->get()->getModifierValue();

$this->assertEquals(PriceAdjuster::ADJUSTER_RELATIVE, $modifierValue->adjusters->price->adjuster);

$this->setReturnData('catalog__products__modifiers__222__values__190__get-no-adjuster.json');

$modifierValue = $this->getApi()
->catalog()->product(1)->modifier(222)->value(190)->get()->getModifierValue();

$this->assertEquals(PriceAdjuster::ADJUSTER_FIXED, $modifierValue->adjusters->price->adjuster);
}
}