Skip to content

Fix Webpack and newer typescript version issues #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: puppeteer@12
Choose a base branch
from
Open

Fix Webpack and newer typescript version issues #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5311124
Change dynamic imports to static imports
belvederef Sep 16, 2021
ec9ca39
Merge branch 'fix/esbuild-bundling' of https://github.com/belvederef/…
deldrid1 Mar 7, 2022
8b8da65
Remove unnecessary types removed in lib.dom.d.ts
deldrid1 Mar 7, 2022
ed2bf7c
Support node16 and 18
bpred754 Apr 4, 2023
3891a02
Merge pull request #2 from bpred754/master
deldrid1 Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/hooks/permissions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export = async function (page: Page): Promise<Page> {
const handler = () => {
let query = window.navigator.permissions.query;

(Permissions as any).prototype.query = function (parameters: DevicePermissionDescriptor | MidiPermissionDescriptor | PermissionDescriptor | PushPermissionDescriptor) {
(Permissions as any).prototype.query = function (parameters: PermissionDescriptor) {
if (parameters?.name?.length > 0) {
return Promise.resolve({
onchange: null,
Expand Down
12 changes: 7 additions & 5 deletions source/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { join } from 'path';
import { PuppeteerNode, Viewport } from 'puppeteer-core';
import { URL } from 'url';

if (/^AWS_Lambda_nodejs(?:10|12|14)[.]x$/.test(process.env.AWS_EXECUTION_ENV) === true) {
if (/^AWS_Lambda_nodejs(?:10|12|14|16|18)[.]x$/.test(process.env.AWS_EXECUTION_ENV) === true) {
if (process.env.FONTCONFIG_PATH === undefined) {
process.env.FONTCONFIG_PATH = '/tmp/aws';
}
Expand Down Expand Up @@ -165,7 +165,7 @@ class Chromium {
LambdaFS.inflate(`${input}/swiftshader.tar.br`),
];

if (/^AWS_Lambda_nodejs(?:10|12|14)[.]x$/.test(process.env.AWS_EXECUTION_ENV) === true) {
if (/^AWS_Lambda_nodejs(?:10|12|14|16|18)[.]x$/.test(process.env.AWS_EXECUTION_ENV) === true) {
promises.push(LambdaFS.inflate(`${input}/aws.tar.br`));
}

Expand Down Expand Up @@ -195,9 +195,11 @@ class Chromium {
* Overloads puppeteer with useful methods and returns the resolved package.
*/
static get puppeteer(): PuppeteerNode {
for (const overload of ['Browser', 'BrowserContext', 'ElementHandle', 'FrameManager', 'Page']) {
require(`${__dirname}/puppeteer/lib/${overload}`);
}
require('./puppeteer/lib/Browser')
require('./puppeteer/lib/BrowserContext')
require('./puppeteer/lib/ElementHandle')
require('./puppeteer/lib/FrameManager')
require('./puppeteer/lib/Page')

try {
return require('puppeteer');
Expand Down