Support --disable-tests configure flag to skip test compilation - #5
Conversation
… tests Add support for a new configure option `--disable-tests` (enabled by default) that controls whether tests and benchmarks are built and run. Expose the `BUILD_TESTS` AM_CONDITIONAL to `Makefile.am` and wrap all test/benchmark targets, variables, and vendored googletest within `if BUILD_TESTS` blocks. This ensures that configuring with `--disable-tests` skips compiling googletest and all test binaries, making the build process much faster and requiring no vendored googletest when only libraries are needed. Co-authored-by: alk <14850+alk@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR implements the requested feature to add a
--disable-testsconfigure flag. By default, tests are still built and run, ensuring no regressions. However, when--disable-testsis specified, all test/benchmark targets,libgtest.laand shell script tests are skipped entirely duringmake allandmake check.PR created automatically by Jules for task 3613786975909440126 started by @alk