Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary check #1117

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Unnecessary check #1117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3a2742
Fix typo in error messages for dimension validation in Splits model
mirkan1 Nov 12, 2024
d44e1da
Fix debounceWithPromise to return a promise by making the callback async
mirkan1 Nov 12, 2024
b6db878
Remove unnecessary dimension type checks in Splits model
mirkan1 Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/common/models/splits/splits.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,19 +134,13 @@ export class Splits extends Record<SplitsValue>(defaultSplits) {
return split;
}
if (splitKind === "time") {
if (splitDimension.kind !== "time") {
throw new Error(`Expected Time Dimension, god ${splitDimension.kind}`);
}
const clause = specificFilter.clauses.find(clause => clause instanceof FixedTimeFilterClause) as FixedTimeFilterClause;
return split.changeBucket(clause
? getBestBucketUnitForRange(clause.values.first(), false, splitDimension.bucketedBy, splitDimension.granularities)
: getDefaultGranularityForKind("time", splitDimension.bucketedBy, splitDimension.granularities)
);

} else if (splitKind === "number") {
if (splitDimension.kind !== "number") {
throw new Error(`Expected Number Dimension, god ${splitDimension.kind}`);
}
const clause = specificFilter.clauses.find(clause => clause instanceof NumberFilterClause) as NumberFilterClause;
return split.changeBucket(clause
? getBestBucketUnitForRange(clause.values.first(), false, splitDimension.bucketedBy, splitDimension.granularities)
Expand Down
2 changes: 1 addition & 1 deletion src/common/utils/functional/functional.mocha.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ describe("Functional utilities", () => {

it("should return promise with value", async () => {
const returnVal = 5;
const debounced = debounceWithPromise(() => returnVal, 10);
const debounced = debounceWithPromise(async () => returnVal, 10);
const x = await debounced();
expect(x).to.be.eq(returnVal);
});
Expand Down