[volumecache 11/12] Add cache path normalization tests#381
Draft
toloudis wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked draft PR 11 of 12 for the refreshed volume cache work.
Base integration branch: feature/volumecache-integration
Review base for this PR: feature/volumecache-pr10-disk-cache-tests
Head branch: feature/volumecache-pr11-path-normalization-tests
This PR adds tests that equivalent local paths normalize to the same cache key while distinct subpaths, scenes, times, channels, regions, sequence flags, and remote URLs remain distinct.
Merge workflow: review bottom-up. After a lower PR lands in feature/volumecache-integration and its branch is deleted or retargeted, the next PR should show only its own delta against the integration branch.
Verification note: local build/test could not complete in this shell because CMake/MSVC cannot link kernel32.lib; this appears to be a missing Windows SDK/MSVC environment issue before project code compiles.