give the statistics view a bit of margin#383
Open
toloudis wants to merge 1 commit into
Open
Conversation
toloudis
requested review from
ShrimpCryptid and
rugeli
and removed request for
a team
rugeli
reviewed
Jun 9, 2026
|
|
||
| QStatisticsDockWidget::QStatisticsDockWidget(QWidget* pParent) | ||
| : QDockWidget(pParent) | ||
| , m_MainWidget(this) |
There was a problem hiding this comment.
pure cpp/qt learning question, not blocking at all: why pass this as parent here, since setWidget()(L16) below should also make it a child?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quick to review
addresses #178 Right padding missing
adds a wrapper widget and gives it a right margin of 8px !