Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P1] Country support for conversation sharing #178

Closed
wants to merge 2 commits into from

Conversation

Stanley-Jovel
Copy link
Collaborator

@Stanley-Jovel Stanley-Jovel commented Mar 6, 2025

Describe the changes

  • Check for country when share button is tapped, if the country is in a list of supported countries (right now just the US is in that list) then server-side share is executed, otherwise share text locally.

Issue ticket number and link

#169

DEMO

  • When region is US, a disclaimber before sharing appears and a request is post to the share lambda. A link to the conversation is shared.
demo.1.mov
  • When region is different than US (i.e. UK), the conversation is shared as plaintext:
demo.2.mov

Checklist before requesting a review

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my code.
  • I have tested my changes and ensured that they work as expected.
  • I have updated examples and documentation as necessary.

@Stanley-Jovel Stanley-Jovel requested a review from jonryser March 6, 2025 01:06
@Stanley-Jovel Stanley-Jovel linked an issue Mar 6, 2025 that may be closed by this pull request
@Stanley-Jovel Stanley-Jovel added this to the SOW-003 milestone Mar 6, 2025
@jonryser jonryser changed the title Country support for conversation sharing [P1} Country support for conversation sharing Mar 6, 2025
@jonryser jonryser changed the title [P1} Country support for conversation sharing [P1] Country support for conversation sharing Mar 6, 2025
@jonryser
Copy link
Collaborator

jonryser commented Mar 7, 2025

No conversation sharing per the Slack conversation:
https://generalui.slack.com/archives/C0812P2LYMN/p1741299126310169?thread_ts=1739914053.657209&cid=C0812P2LYMN

Hello
@Taira A
,
As per SOW-3, the server-side share feature has been reinstated but is currently limited to selected countries, with the US being the only supported country for now. However, the v2 text for the Privacy and Data Collection section states:
OLMoE runs locally on your device and Ai2 will not collect your interactions with the app. OLMoE only stores your most recent conversation and you can manually delete each conversation by starting a new thread. Ai2 will receive anonymized app development data though Apple's crash analytics APIs in accordance with our Privacy Policy. Please use your discretion and best judgment when sharing any personal, sensitive, or confidential information in your use of the OLMoE app.
Additionally, the v2_updates document includes an instruction stating:
“Share Disclaimer (not available for v2; remove all sharing text).”
Could you clarify whether the share feature is officially being reinstated? If so, the Privacy and Data Collection copy may need to be updated to reflect that data collection currently applies only in the US.
Thanks!

Luca Soldaini
Today at 2:20 PM
we wanna keep if off everywhere, even for some US states we don’t think the current mechanism is compliant

Stanley Jovel
Today at 2:21 PM
Oh, I see. Thanks for the clarification!

Taira Anderson
Today at 2:24 PM
thank you
@luca [they/them]
!!

@jonryser jonryser closed this Mar 7, 2025
@Stanley-Jovel Stanley-Jovel deleted the 169/region-lock-share-button branch March 7, 2025 19:23
@Stanley-Jovel Stanley-Jovel restored the 169/region-lock-share-button branch March 7, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NO LONGER IN SCOPE] Share button enablement based on country
2 participants