Support for WARC resource record types. #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WARC resource records store "a resource retrieved over a network, but not necessarily as a direct result of a single HTTP request/response exchange." These records can omit http headers, making the prior code which relied on http header presence problematic. Here were add a simple method to resolve the attribute values necessary to process records for linearization.
|
looks good, not sure why python style is failing tho! |
soldni
approved these changes
Mar 4, 2025
Some cleanup on the code organization to introduce support for resource WARC record types. Improved safety. Also linting.
|
@soldni Just introduced a small refactor that cleaned things up a bit. On the plus side, got to move just a little code out of processor. Will mark as draft pr next time 😜 -- thanks for quick review. |
Whattabatt
approved these changes
Mar 4, 2025
Yes. Here's a sample record based on sponge data. There is a remaining problem of detecting non-character encodings that is outstanding, and may require further quality checks with warnings, exceptions, or remediation, which may make sense to have in the processor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARC resource records store "a resource retrieved over a network, but not necessarily as a direct result of a single HTTP request/response exchange."
These records can omit http headers, making the prior code which relied on http header presence problematic. Here were add a simple method to resolve the attribute values necessary to process records for linearization.