Report cumulative vLLM generation progress across batches#179
Open
finbarrtimbers wants to merge 1 commit into
Open
Report cumulative vLLM generation progress across batches#179finbarrtimbers wants to merge 1 commit into
finbarrtimbers wants to merge 1 commit into
Conversation
…-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BeakerStatusReporter.start_accumulator/accumulating_callbackso progress can be reported as a single cumulative counter across batches.VLLMServerProviderto use the accumulator when the runner exposesOLMO_VLLM_GEN_TOTAL, falling back to per-batch reporting otherwise.OLMO_VLLM_GEN_TOTAL(sum oftotal_instances * num_samples) andOLMO_EVAL_BENCHMARKso the provider can label progress with the experiment name.Test plan
🤖 Generated with Claude Code