Use encrypted Modal sandbox tunnels#237
Open
abhinav-bellapu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the Modal sandbox deprecation warning described in #141 by exposing the SWE-ReX runtime port through
encrypted_portsinstead ofunencrypted_ports.SWE-ReX currently hard-codes
unencrypted_ports=[self._port]when creating its Modal sandbox. That means olmo-eval cannot fix the warning by passingmodal_sandbox_kwargs: providingencrypted_portsthere would still leave the deprecated unencrypted runtime port in place, and providing either port key can conflict with the hard-coded argument.This change keeps the existing SWE-ReX Modal startup flow, but wraps the deployment class that olmo-eval constructs so the runtime port is requested as an encrypted tunnel. User-provided
encrypted_portsare preserved, the runtime port is appended if needed, and deprecatedunencrypted_portsentries are dropped from forwarded sandbox kwargs. Docker and local sandbox modes are unchanged.Reviewer notes:
modaland SWE-ReX modules, so it verifies the port kwargs without requiring Modal credentials or network access.Closes #141
Type of Change
Testing
pytest tests/ --ignore=tests/integration/)Local checks run:
uv run --no-group vllm pytest tests/core/harness/test_sandbox_executor.pyuv run --no-group vllm pytest tests/core/harnessuv run --no-group vllm ruff check src/ tests/uv run --no-group vllm ruff format --check src/ tests/uv run --no-group vllm ty check src/ alembic/(exits 0; reports existing unusedtype: ignorewarnings in optional SWE-ReX paths)uv run --no-group vllm pytest tests/ --ignore=tests/integration/(1711 passed, 6 skipped)Checklist