Fast geometry to_projection when dst crs matches src crs. #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main motivation was to increase the speed of rtree index creation in the gcp_public_data data source. It seems rasterio.warp.transform_geom takes 10+ ms even when the src/dst CRS are the same, so skipping the call saves a lot of time when we are doing many re-projections.
APatrickJ
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
I think I've made this same optimization in the past. I was curious if there's an equivalence check similar to what pyproj offers, but as these are rasterio.crs objects I didn't find one. Anyway, I'm sure this is already a huge win!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation was to increase the speed of rtree index creation in the gcp_public_data data source. It seems rasterio.warp.transform_geom takes 10+ ms even when the src/dst CRS are the same, so skipping the call saves a lot of time when we are doing many re-projections.