Skip to content

Do not run NCalcEMA if already at same value#737

Merged
xmariachi merged 2 commits intodevfrom
diego/proto-3272-reputers-will-not-be-properly-penalised
Apr 7, 2025
Merged

Do not run NCalcEMA if already at same value#737
xmariachi merged 2 commits intodevfrom
diego/proto-3272-reputers-will-not-be-properly-penalised

Conversation

@xmariachi
Copy link
Copy Markdown
Contributor

@xmariachi xmariachi commented Jan 20, 2025 •
edited
Loading

Purpose of Changes and their Description

Efficiency: do not run NCalcEMA if already at same value

Are these changes tested and documented?

  • If tested, please describe how. If not, why tests are not needed. -- unit tests
  • If documented, please describe where. If not, describe why docs are not needed. -- no need, just optim
  • Added to Unreleased section of CHANGELOG.md?

@xmariachi xmariachi changed the title Optimize: do not run NCalcEMA if already at same value Do not run NCalcEMA if already at same value Jan 20, 2025
@xmariachi xmariachi marked this pull request as ready for review January 20, 2025 17:52
amimart
amimart previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

kpeluso
kpeluso previously approved these changes Mar 10, 2025
View reviewed changes
@xmariachi xmariachi dismissed stale reviews from kpeluso and amimart via 997b23e March 11, 2025 10:03
@xmariachi xmariachi force-pushed the diego/proto-3272-reputers-will-not-be-properly-penalised branch from 8904479 to 997b23e Compare March 11, 2025 10:03
amimart
amimart previously approved these changes Mar 11, 2025
View reviewed changes
@xmariachi xmariachi force-pushed the diego/proto-3272-reputers-will-not-be-properly-penalised branch from 997b23e to 172b30d Compare March 13, 2025 12:33
amimart
amimart previously approved these changes Mar 13, 2025
View reviewed changes
@xmariachi xmariachi force-pushed the diego/proto-3272-reputers-will-not-be-properly-penalised branch from 172b30d to 3794356 Compare April 7, 2025 11:31
@xmariachi xmariachi force-pushed the diego/proto-3272-reputers-will-not-be-properly-penalised branch from 3794356 to 8c60d11 Compare April 7, 2025 11:41
@xmariachi xmariachi merged commit 7c5d49e into dev Apr 7, 2025
9 checks passed
@xmariachi xmariachi deleted the diego/proto-3272-reputers-will-not-be-properly-penalised branch April 7, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spooktheducks spooktheducks Awaiting requested review from spooktheducks spooktheducks is a code owner

4 more reviewers

@fernandofcampos fernandofcampos fernandofcampos approved these changes

@amimart amimart amimart approved these changes

@guilherme-brandao guilherme-brandao guilherme-brandao approved these changes

@kpeluso kpeluso kpeluso left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xmariachi @fernandofcampos @kpeluso @amimart @guilherme-brandao