Skip to content

Sealing the sdk config#738

Merged
xmariachi merged 2 commits intodevfrom
diego/proto-3275-seal-config-on-chain
Feb 4, 2025
Merged

Sealing the sdk config#738
xmariachi merged 2 commits intodevfrom
diego/proto-3275-seal-config-on-chain

Conversation

@xmariachi
Copy link
Contributor

@xmariachi xmariachi commented Jan 21, 2025

Purpose of Changes and their Description

Sealing the sdk config to prevent modifications.
Aligned with other networks in where this is placed (initRootCmd)

Are these changes tested and documented?

  • If tested, please describe how. If not, why tests are not needed. -- tested running chain locally
  • If documented, please describe where. If not, describe why docs are not needed. -- no need, standard practice, not user facing
  • Added to Unreleased section of CHANGELOG.md?

@xmariachi xmariachi marked this pull request as ready for review January 21, 2025 13:27
Copy link
Contributor

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@xmariachi xmariachi merged commit fd7bcbb into dev Feb 4, 2025
9 checks passed
@xmariachi xmariachi deleted the diego/proto-3275-seal-config-on-chain branch February 4, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants