Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf Linter / buf (pull_request).
|
94c489d to
44f4640
Compare
felipead
reviewed
Feb 19, 2025
felipead
reviewed
Feb 19, 2025
kpeluso
reviewed
Feb 19, 2025
kpeluso
reviewed
Feb 19, 2025
amimart
suggested changes
Feb 19, 2025
Contributor
amimart
left a comment
There was a problem hiding this comment.
Great job thx!
I've made some remarks, the main point is to introduce a new migration for the next software upgrade to v0.9.0.
kpeluso
suggested changes
Feb 19, 2025
Contributor
kpeluso
left a comment
There was a problem hiding this comment.
Few comments + Upgrade Flow then gtg
amimart
reviewed
Feb 20, 2025
more efficient allocation of arrays Co-authored-by: Arnaud Mimart <33665250+amimart@users.noreply.github.com> Signed-off-by: Diego C <xmariachi@gmail.com>
1ce5007 to
93d82b9
Compare
kpeluso
previously approved these changes
Feb 20, 2025
kpeluso
previously approved these changes
Feb 20, 2025
amimart
reviewed
Feb 20, 2025
kpeluso
approved these changes
Feb 21, 2025
fernandofcampos
approved these changes
Feb 21, 2025
Contributor
fernandofcampos
left a comment
There was a problem hiding this comment.
LGTM. Great job, especially with the test coverage.
felipead
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
This PR implements the rework on weights that fixes the latest outlier issues observed from experience and provides a cutoff on low weights for the stddev.
CloseReputerNonce, calculate stdnorm based on old weights, store it and recalculate weights.Link(s) to Ticket(s) or Issue(s) resolved by this PR
Are these changes tested and documented?
Tested with allora-simulator. The expectations from research are met.
Internal implementation details, no need to post to the user.
Unreleasedsection ofCHANGELOG.md?Still Left Todo