Skip to content

Add nonce to rewards events#748

Merged
xmariachi merged 2 commits intodevfrom
diego/engn-3406-rewards-block-event-emission
Feb 20, 2025
Merged

Add nonce to rewards events#748
xmariachi merged 2 commits intodevfrom
diego/engn-3406-rewards-block-event-emission

Conversation

@xmariachi
Copy link
Contributor

@xmariachi xmariachi commented Feb 17, 2025

Purpose of Changes and their Description

  • Emit nonce (and also blockheight_tx) on rewards events. This aligns rewards with other events that use nonce.

Are these changes tested and documented?

  • If tested, please describe how. If not, why tests are not needed. -- Covered by unit tests.
  • If documented, please describe where. If not, describe why docs are not needed. -- no need, this change does not modify behaviour
  • Added to Unreleased section of CHANGELOG.md?

@xmariachi xmariachi changed the base branch from dev to release-v0.9.0 February 17, 2025 19:41
@github-actions
Copy link

github-actions bot commented Feb 17, 2025

The latest Buf updates on your PR. Results from workflow Buf Linter / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed⏩ skippedFeb 17, 2025, 11:42 PM

@xmariachi xmariachi marked this pull request as ready for review February 17, 2025 23:28
@xmariachi xmariachi force-pushed the diego/engn-3406-rewards-block-event-emission branch from a73938f to ebe5700 Compare February 17, 2025 23:41
@xmariachi xmariachi changed the base branch from release-v0.9.0 to dev February 18, 2025 19:05
@xmariachi xmariachi dismissed fernandofcampos’s stale review February 18, 2025 19:05

The base branch was changed.

Copy link
Contributor

@kpeluso kpeluso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

Copy link
Contributor

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmariachi xmariachi merged commit 39ecc9c into dev Feb 20, 2025
10 checks passed
@xmariachi xmariachi deleted the diego/engn-3406-rewards-block-event-emission branch February 20, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants