Conversation
xmariachi
force-pushed
the
diego/proto-3256-totalsumprevioustopicweights-can-be-set-to-any-value
branch
from
d9f71ed to
e0539c4
Compare
amimart
reviewed
Mar 5, 2025
amimart
reviewed
Mar 5, 2025
amimart
previously approved these changes
Mar 5, 2025
Contributor
amimart
left a comment
amimart
left a comment
There was a problem hiding this comment.
Sounds good thanks, just noticed minor simplification
amimart
previously approved these changes
Mar 11, 2025
guilherme-brandao
previously approved these changes
Mar 14, 2025
xmariachi
dismissed stale reviews from guilherme-brandao and amimart
via
7faf946
xmariachi
force-pushed
the
diego/proto-3256-totalsumprevioustopicweights-can-be-set-to-any-value
branch
from
d4e56b0 to
7faf946
Compare
amimart
previously approved these changes
Mar 14, 2025
Co-authored-by: Arnaud Mimart <33665250+amimart@users.noreply.github.com> Signed-off-by: Diego C <xmariachi@gmail.com>
xmariachi
force-pushed
the
diego/proto-3256-totalsumprevioustopicweights-can-be-set-to-any-value
branch
from
7faf946 to
730b761
Compare
amimart
approved these changes
Mar 14, 2025
fernandofcampos
approved these changes
Mar 14, 2025
kpeluso
reviewed
Mar 14, 2025
xmariachi
changed the title
guilherme-brandao
approved these changes
Mar 18, 2025
xmariachi
deleted the
diego/proto-3256-totalsumprevioustopicweights-can-be-set-to-any-value
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
isAdded, errorfor justerroronaddTopicToActiveSetRespectingLimitsWithoutMinWeightReset, adding some error types. The flag was not really adding value, while not processing the flag would lead to a vulnerability like the one found.Are these changes tested and documented?
Unreleasedsection ofCHANGELOG.md?