Add one out forecast-implied inference in network inference bundle#772
Conversation
There was a problem hiding this comment.
This contains a triple-nested for.
I am concerned about the time this will take when executing in an endBlocker.
Could we time-measure this by having a full max inferers and max forecasters test?
If this has an impact we want to know ... it could add some non-negligible time to the block
cc @spooktheducks @amimart
It seems to be used on queries only so it should not impact block production |
amimart
left a comment
There was a problem hiding this comment.
I've let some time/alloc optimization remarks to see if we can improve it
x/emissions/keeper/inference_synthesis/network_inference_builder.go
Outdated
Show resolved
Hide resolved
amimart
left a comment
There was a problem hiding this comment.
Left some comments that may be great to discuss
cd50837 to
42a2a38
Compare
I think this was left unreplied, but just for completeness: this is internalized into endblocker in another PR |
Purpose of Changes and their Description
This PR adds a new feature to calculate forecast-implied inferences when each inferer is removed from the network. These values are critical for evaluating the influence of individual inferers on forecasters' implied predictions.
GetOneOutInfererForecastImpliedInferencesfunction to calculate what each forecaster's implied inference would be when each inferer is removedCalcNetworkInferencesto include these values in the network inference bundleOneOutInfererForecasterValuestype to maintain consistent structure with other one-out calculationsPerformance Related Changes:
Exp) to avoid redundant calculations during network inference processing; the cache is enabled at the function's start, utilized during calculations, and then intentionally disabled and cleared upon completion.Link(s) to Ticket(s) or Issue(s) resolved by this PR
Are these changes tested and documented?
✅ Added new unit tests
Data Submissionsection to./README.md.Unreleasedsection ofCHANGELOG.md?