Fix: ensure consistent content in reputer value bundle#774
Closed
Fix: ensure consistent content in reputer value bundle#774
Conversation
67fc4c1 to
d5487ea
Compare
d5487ea to
f9eb485
Compare
f9eb485 to
635451b
Compare
Contributor
Author
|
Closing in favour of #812 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
Add some checks upon reputer
ValueBundle, please review carefully these added checks to ensure they don't prevent allowed inputs.Here are the added stateless validations when constructing the bundle:
InfererValuesandOneOutInfererValues;ForecasterValues,OneOutForecasterValuesandOneInForecasterValues;OneOutInfererForecasterValuescontains all forecasters, and all inferers for each;As these checks ensured upon submission, I've removed some validations that were made in the reputer nonce closing.
Are these changes tested and documented?
Unreleasedsection ofCHANGELOG.md?