Skip to content

Fix: ensure consistent content in reputer value bundle#774

Closed
amimart wants to merge 8 commits intodevfrom
arnaud/engn-3542-184-invalid-array-relationship-assumption-bw
Closed

Fix: ensure consistent content in reputer value bundle#774
amimart wants to merge 8 commits intodevfrom
arnaud/engn-3542-184-invalid-array-relationship-assumption-bw

Conversation

@amimart
Copy link
Contributor

@amimart amimart commented Mar 19, 2025

Purpose of Changes and their Description

Add some checks upon reputer ValueBundle, please review carefully these added checks to ensure they don't prevent allowed inputs.

Here are the added stateless validations when constructing the bundle:

  • No duplicate inferers;
  • No duplicate forecasters;
  • Identical inferers in InfererValues and OneOutInfererValues;
  • Identical forecasters in ForecasterValues, OneOutForecasterValues and OneInForecasterValues;
  • OneOutInfererForecasterValues contains all forecasters, and all inferers for each;

As these checks ensured upon submission, I've removed some validations that were made in the reputer nonce closing.

Are these changes tested and documented?

  • If tested, please describe how. If not, why tests are not needed.
  • If documented, please describe where. If not, describe why docs are not needed.
  • Added to Unreleased section of CHANGELOG.md?

@amimart amimart force-pushed the arnaud/engn-3542-184-invalid-array-relationship-assumption-bw branch from 67fc4c1 to d5487ea Compare March 20, 2025 10:45
@amimart amimart marked this pull request as ready for review March 20, 2025 14:41
@amimart amimart marked this pull request as draft March 20, 2025 14:41
@amimart amimart force-pushed the arnaud/engn-3542-184-invalid-array-relationship-assumption-bw branch from d5487ea to f9eb485 Compare March 27, 2025 11:56
@amimart amimart force-pushed the arnaud/engn-3542-184-invalid-array-relationship-assumption-bw branch from f9eb485 to 635451b Compare April 24, 2025 09:45
@amimart
Copy link
Contributor Author

amimart commented May 5, 2025

Closing in favour of #812

@amimart amimart closed this May 5, 2025
@amimart amimart deleted the arnaud/engn-3542-184-invalid-array-relationship-assumption-bw branch May 5, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant