Skip to content

target weight: rm div by topic epochLength#776

Merged
xmariachi merged 3 commits intodevfrom
diego/engn-3565-remove-epochlength-division-on-target-weight-calculation
Mar 21, 2025
Merged

target weight: rm div by topic epochLength#776
xmariachi merged 3 commits intodevfrom
diego/engn-3565-remove-epochlength-division-on-target-weight-calculation

Conversation

@xmariachi
Copy link
Contributor

@xmariachi xmariachi commented Mar 19, 2025

Purpose of Changes and their Description

  • Fix problem: topics with shorter epochLengths got higher target weights, but there's no justification for this.
  • Alignment with whitepaper: target weights are not dependent on epochLength.
  • Added / modified tests.
  • v3 migration contains a call to this getTargetWeight function. Previous impl of the function has been internalized in the migration.

Are these changes tested and documented?

  • If tested, please describe how. If not, why tests are not needed. -- Unit tests fixed
  • If documented, please describe where. If not, describe why docs are not needed. -- No need, just aligment with whitepaper.
  • Added to Unreleased section of CHANGELOG.md?

@xmariachi xmariachi changed the title target weight: rm div by topic epochLength as per whitepaper target weight: rm div by topic epochLength Mar 19, 2025
@xmariachi xmariachi marked this pull request as ready for review March 19, 2025 18:10
Copy link
Contributor

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx 🙏

@xmariachi xmariachi merged commit 302329e into dev Mar 21, 2025
9 checks passed
@xmariachi xmariachi deleted the diego/engn-3565-remove-epochlength-division-on-target-weight-calculation branch March 21, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants