Fix max distant value in stake weighted calc#779
Merged
guilherme-brandao merged 4 commits intodevfrom Mar 27, 2025
Merged
Conversation
xmariachi
requested changes
Mar 23, 2025
Contributor
xmariachi
left a comment
xmariachi
left a comment
There was a problem hiding this comment.
Left a suggestion, otherwise lgtm.
amimart
reviewed
Mar 24, 2025
amimart
approved these changes
Mar 24, 2025
fernandofcampos
approved these changes
Mar 25, 2025
xmariachi
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
This PR improves the implementation of GetStakeWeightedLossMatrix to correctly identify the most distant value from the consensus using absolute differences. The function is used to calculate stake-weighted loss matrices and identify outliers in reported losses.
Link(s) to Ticket(s) or Issue(s) resolved by this PR
https://linear.app/alloralabs/issue/ENGN-3540/182-incorrect-maxdistant-value-causes-reputers-who-havent-submitted