Merged
Conversation
xmariachi
requested review from
KjetilVaa,
amimart,
felipead,
fernandofcampos,
guilherme-brandao and
spooktheducks
guilherme-brandao
previously approved these changes
Mar 28, 2025
amimart
reviewed
Mar 28, 2025
Contributor
amimart
left a comment
amimart
left a comment
There was a problem hiding this comment.
Here's a slight suggestion :)
Co-authored-by: Arnaud Mimart <33665250+amimart@users.noreply.github.com> Signed-off-by: Diego C <xmariachi@gmail.com>
amimart
approved these changes
Mar 28, 2025
guilherme-brandao
approved these changes
Mar 28, 2025
xmariachi
deleted the
diego/engn-3587-add-api-breaking-changes-to-changelog
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
Add API Breaking Changes section
Link(s) to Ticket(s) or Issue(s) resolved by this PR
ENGN-3587
Are these changes tested and documented?
Unreleasedsection ofCHANGELOG.md?