Skip to content

Optim: do not recalc networkInfs if no outliers#784

Merged
xmariachi merged 3 commits intodevfrom
diego/engn-3588-outlier-resistant-network-inferences-only-calculate-if
Mar 31, 2025
Merged

Optim: do not recalc networkInfs if no outliers#784
xmariachi merged 3 commits intodevfrom
diego/engn-3588-outlier-resistant-network-inferences-only-calculate-if

Conversation

@xmariachi
Copy link
Contributor

@xmariachi xmariachi commented Mar 28, 2025 •
edited
Loading

Purpose of Changes and their Description

  • Do not recalculate outlier-resistant version of network inferences if no outliers.
  • Refactor network inference code into function, added two unit tests w and w/o outliers
  • Refactor function names to align
  • Other cleaning

Link(s) to Ticket(s) or Issue(s) resolved by this PR

ENGN-3588

Are these changes tested and documented?

  • If tested, please describe how. If not, why tests are not needed. -- current unit tests and added new ones
  • If documented, please describe where. If not, describe why docs are not needed. -- no need, optim + refactor
  • Added to Unreleased section of CHANGELOG.md?

amimart
amimart approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch!

@xmariachi xmariachi marked this pull request as ready for review March 28, 2025 14:15
@xmariachi xmariachi merged commit f95e804 into dev Mar 31, 2025
9 checks passed
@xmariachi xmariachi deleted the diego/engn-3588-outlier-resistant-network-inferences-only-calculate-if branch March 31, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fernandofcampos fernandofcampos Awaiting requested review from fernandofcampos

@spooktheducks spooktheducks Awaiting requested review from spooktheducks spooktheducks is a code owner

2 more reviewers

@amimart amimart amimart approved these changes

@guilherme-brandao guilherme-brandao guilherme-brandao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xmariachi @amimart @guilherme-brandao