Optimize topic weights fetch and update flow#794
Merged
guilherme-brandao merged 7 commits intodevfrom Apr 7, 2025
Merged
Conversation
xmariachi
requested changes
Apr 4, 2025
Contributor
xmariachi
left a comment
There was a problem hiding this comment.
small change but otherwise lgtm
amimart
reviewed
Apr 4, 2025
Contributor
amimart
left a comment
There was a problem hiding this comment.
Just small remarks I'll let up to you
Contributor
|
Needs fixing linter and compilation is failing in tests, otherwise it lgtm. |
4aafc96 to
61d9bc3
Compare
amimart
previously approved these changes
Apr 7, 2025
xmariachi
requested changes
Apr 7, 2025
Contributor
xmariachi
left a comment
There was a problem hiding this comment.
Add to changelog, otherwise lgtm, good work
amimart
approved these changes
Apr 7, 2025
xmariachi
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
GetCurrentTopicWeightandDripTopicFeeRevenueLink(s) to Ticket(s) or Issue(s) resolved by this PR
No ticket was created for this. This optimization opportunity was found during the execution of this ticket:
https://linear.app/alloralabs/issue/ENGN-3608/test-topic-weight-changes
Are these changes tested and documented?
Unreleasedsection ofCHANGELOG.md?