Add reset/cleanup functions to defer in close nonce

[guilherme-brandao]

Purpose of Changes and their Description

This PR enhances the robustness of the CloseReputerNonce function by implementing a defer block to ensure critical cleanup operations (fulfilling the nonce, resetting active reputers, resetting submissions) are always executed, even if errors occur during the processing of reputer bundles.

The primary goal is to prevent the system from getting stuck in an inconsistent state if CloseReputerNonce fails mid-execution. By guaranteeing cleanup actions via defer, we ensure the nonce is properly fulfilled and associated state (active reputers, submissions) is reset, improving the reliability of the nonce management and reward distribution process.

Link(s) to Ticket(s) or Issue(s) resolved by this PR

https://linear.app/alloralabs/issue/ENGN-3672/required-functions-not-being-called-not-deferd

Are these changes tested and documented?

• If tested, please describe how. If not, why tests are not needed.
• If documented, please describe where. If not, describe why docs are not needed.
• Added to Unreleased section of CHANGELOG.md?

Still Left Todo

• PR Review
• Check if more tests need to be done

[xmariachi]

Please do similarly for the CloseWorkerNonce counterparts: ResetActiveWorkersForTopic , ResetWorkersIndividualSubmissionsForTopic, FulfillWorkerNonce

[xmariachi]

Additionally.
I think we should move these into its own function and take them up to the point where we calculate the (topic, block) activity - so when we detect this, we can call defer these operations that we want to happen in any case.

For example, in this function we detect that and ultimately we CloseReputerNonce. However, if there is any error in between, CloseReputerNonce won't be called and thus the cleaning won't happen.

So I believe we should move both function cleanings (worker, reputer) closest to the point where the (topic, block) is detected (and thus we know we need to ultimately clean).

[xmariachi]

an additional comment, lgtm otherwise

[xmariachi]

lgtm!

[amimart]

LGTM

[zale144]

lgtm