Skip to content

Additional validations + use inferenceBlockheight in NetworkInferences#804

Merged
xmariachi merged 1 commit intodevfrom
diego/engn-3671-validations-on-input-data-completeness
Apr 16, 2025
Merged

Additional validations + use inferenceBlockheight in NetworkInferences#804
xmariachi merged 1 commit intodevfrom
diego/engn-3671-validations-on-input-data-completeness

Conversation

@xmariachi
Copy link
Contributor

@xmariachi xmariachi commented Apr 14, 2025

Purpose of Changes and their Description

  • Additional validations on validations.go

    • nonempty infererValues is required
    • input data blockheight is required to be non-nil and non-zero
    • inference and forecasts blockheight need to be aligned with bundle blockheight
  • fix usage of current block ctx.Blockheight() in inferenceBlockheight in NetworkInferences responses.

Are these changes tested and documented?

  • If tested, please describe how. If not, why tests are not needed. -- unit tests fixed + cases added.
  • If documented, please describe where. If not, describe why docs are not needed. -- no need to document, not relevant functional changes.
  • Added to Unreleased section of CHANGELOG.md?

@xmariachi xmariachi marked this pull request as ready for review April 14, 2025 20:07
Copy link
Contributor

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmariachi xmariachi merged commit 1b932e0 into dev Apr 16, 2025
9 checks passed
@xmariachi xmariachi deleted the diego/engn-3671-validations-on-input-data-completeness branch April 16, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants