Skip to content

An invalid loss bundle gets ignored on networkLoss calc#805

Merged
xmariachi merged 2 commits intodevfrom
diego/engn-3673-review-whole-set-of-bundles-is-removed-if-only-one-is-not
Apr 16, 2025
Merged

An invalid loss bundle gets ignored on networkLoss calc#805
xmariachi merged 2 commits intodevfrom
diego/engn-3673-review-whole-set-of-bundles-is-removed-if-only-one-is-not

Conversation

@xmariachi
Copy link
Contributor

@xmariachi xmariachi commented Apr 15, 2025 •
edited
Loading

Purpose of Changes and their Description

  • If one bundle has an invalid topicId or blockHeight, it will not invalidate the network losses completely - it will just be ignored.
  • Added unit tests and refactored a comparison function.

Are these changes tested and documented?

  • If tested, please describe how. If not, why tests are not needed. -- added unit tests
  • If documented, please describe where. If not, describe why docs are not needed. -- change of functionality is minimal
  • Added to Unreleased section of CHANGELOG.md?

@xmariachi xmariachi changed the title One invalid bundle does not break networkLoss + unit tests + refactor One invalid bundle gets ignored on networkLoss calc Apr 15, 2025
@xmariachi xmariachi changed the title One invalid bundle gets ignored on networkLoss calc One invalid loss bundle gets ignored on networkLoss calc Apr 15, 2025
@xmariachi xmariachi changed the title One invalid loss bundle gets ignored on networkLoss calc An invalid loss bundle gets ignored on networkLoss calc Apr 15, 2025
@xmariachi xmariachi marked this pull request as ready for review April 15, 2025 15:32
@xmariachi xmariachi assigned zale144 and unassigned zale144 Apr 15, 2025
@xmariachi xmariachi merged commit 56b42c0 into dev Apr 16, 2025
9 checks passed
@xmariachi xmariachi deleted the diego/engn-3673-review-whole-set-of-bundles-is-removed-if-only-one-is-not branch April 16, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fernandofcampos fernandofcampos Awaiting requested review from fernandofcampos

@spooktheducks spooktheducks Awaiting requested review from spooktheducks spooktheducks is a code owner

@zale144 zale144 Awaiting requested review from zale144 zale144 is a code owner

2 more reviewers

@amimart amimart amimart approved these changes

@guilherme-brandao guilherme-brandao guilherme-brandao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xmariachi @amimart @guilherme-brandao @zale144