Mint module metrics + refactor on metric names#819
Merged
Conversation
xmariachi
requested review from
amimart,
felipead,
guilherme-brandao,
mmallora and
spooktheducks
mmallora
previously approved these changes
May 9, 2025
mmallora
left a comment
mmallora
left a comment
There was a problem hiding this comment.
Good! @felipead @spooktheducks please add your thoughts or approve.
amimart
reviewed
May 9, 2025
spooktheducks
previously approved these changes
May 9, 2025
felipead
previously approved these changes
May 9, 2025
Co-authored-by: Arnaud Mimart <33665250+amimart@users.noreply.github.com> Signed-off-by: Diego C <xmariachi@gmail.com>
Co-authored-by: Arnaud Mimart <33665250+amimart@users.noreply.github.com> Signed-off-by: Diego C <xmariachi@gmail.com>
xmariachi
force-pushed
the
diego/engn-3570-monitoring-onchain-mint-refactor
branch
from
ac1642e to
cbff770
Compare
amimart
approved these changes
May 9, 2025
guilherme-brandao
approved these changes
May 12, 2025
zale144
pushed a commit
that referenced
this pull request
Jun 2, 2025
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! You're awesome! ✰ v Please note that maintainers will only review those PRs with a completed PR template. ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> ## Purpose of Changes and their Description * Add mint metrics on events ## Are these changes tested and documented? - [x] If tested, please describe how. If not, why tests are not needed. -- unit and integration tests - [x] If documented, please describe where. If not, describe why docs are not needed. -- fixed docs on module `README`s - [x] Added to `Unreleased` section of `CHANGELOG.md`? --------- Signed-off-by: Diego C <xmariachi@gmail.com> Co-authored-by: Arnaud Mimart <33665250+amimart@users.noreply.github.com>
zale144
pushed a commit
that referenced
this pull request
Jun 2, 2025
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! You're awesome! ✰ v Please note that maintainers will only review those PRs with a completed PR template. ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> ## Purpose of Changes and their Description * Add mint metrics on events ## Are these changes tested and documented? - [x] If tested, please describe how. If not, why tests are not needed. -- unit and integration tests - [x] If documented, please describe where. If not, describe why docs are not needed. -- fixed docs on module `README`s - [x] Added to `Unreleased` section of `CHANGELOG.md`? --------- Signed-off-by: Diego C <xmariachi@gmail.com> Co-authored-by: Arnaud Mimart <33665250+amimart@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
Are these changes tested and documented?
READMEsUnreleasedsection ofCHANGELOG.md?