bank dedupe and cleanup, guard, log, comments#924
Merged
xmariachi merged 1 commit intoalek/restructure-emissions-keeperfrom Mar 3, 2026
Merged
bank dedupe and cleanup, guard, log, comments#924xmariachi merged 1 commit intoalek/restructure-emissions-keeperfrom
xmariachi merged 1 commit intoalek/restructure-emissions-keeperfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
xmariachi
force-pushed
the
fix/pr919-banking-cleanup
branch
from
43fee65 to
fc29bdd
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
xmariachi
added a commit
that referenced
this pull request
Mar 9, 2026
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! You're awesome! ✰ v Please note that maintainers will only review those PRs with a completed PR template. ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> ## Purpose of Changes and their Description Bank deduping, clarity, guards, log / comments fixed. ## Are these changes tested and documented? - [x] If tested, please describe how. If not, why tests are not needed. -- unit tests passed. No functionality change. - [ ] If documented, please describe where. If not, describe why docs are not needed. -- not needed, no functionality change - [ ] Added to `Unreleased` section of `CHANGELOG.md`? -- not needed, no functionality change <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Unified bank balance lookups under GetBalance and switched all call sites. Added a guard to block negative transfers from rewards to ecosystem, and tightened error text and comments. - **Refactors** - Replaced GetBankBalance with GetBalance and removed the duplicate wrapper. - Updated invariants, msgserver, and reward distribution to use GetBalance. - Clarified score EMA comments to reflect (topic, actor) keys. - **Bug Fixes** - Prevent negative amounts in MoveCoinsFromAlloraRewardsToEcosystem. - More accurate error message in GetTotalSumPreviousTopicWeights. <sup>Written for commit fc29bdd. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. -->
xmariachi
added a commit
that referenced
this pull request
Mar 9, 2026
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! You're awesome! ✰ v Please note that maintainers will only review those PRs with a completed PR template. ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> ## Purpose of Changes and their Description Bank deduping, clarity, guards, log / comments fixed. ## Are these changes tested and documented? - [x] If tested, please describe how. If not, why tests are not needed. -- unit tests passed. No functionality change. - [ ] If documented, please describe where. If not, describe why docs are not needed. -- not needed, no functionality change - [ ] Added to `Unreleased` section of `CHANGELOG.md`? -- not needed, no functionality change <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Unified bank balance lookups under GetBalance and switched all call sites. Added a guard to block negative transfers from rewards to ecosystem, and tightened error text and comments. - **Refactors** - Replaced GetBankBalance with GetBalance and removed the duplicate wrapper. - Updated invariants, msgserver, and reward distribution to use GetBalance. - Clarified score EMA comments to reflect (topic, actor) keys. - **Bug Fixes** - Prevent negative amounts in MoveCoinsFromAlloraRewardsToEcosystem. - More accurate error message in GetTotalSumPreviousTopicWeights. <sup>Written for commit fc29bdd. Summary will update on new commits.</sup> <!-- End of auto-generated description by cubic. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
Bank deduping, clarity, guards, log / comments fixed.
Are these changes tested and documented?
Unreleasedsection ofCHANGELOG.md? -- not needed, no functionality changeSummary by cubic
Unified bank balance lookups under GetBalance and switched all call sites. Added a guard to block negative transfers from rewards to ecosystem, and tightened error text and comments.
Refactors
Bug Fixes
Written for commit fc29bdd. Summary will update on new commits.