Skip to content

feat!: ban BITS == 0#575

Closed
DaniPopes wants to merge 1 commit into
alloy-rs:mainfrom
DaniPopes:ban-bits-zero
Closed

feat!: ban BITS == 0#575
DaniPopes wants to merge 1 commit into
alloy-rs:mainfrom
DaniPopes:ban-bits-zero

Conversation

@DaniPopes
Copy link
Copy Markdown
Member

This way too many branches for something that is practically useless. This should've never been allowed.

I'm pretty confident nobody is using this. If there is, we can always revert this.

@DaniPopes DaniPopes requested a review from prestwich as a code owner April 25, 2026 01:23
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 25, 2026

Merging this PR will improve performance by 11.06%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
✅ 383 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
most_significant_bits/4096/4096 29 µs 26.1 µs +10.98%
to/f32/4096 29.1 µs 26.3 µs +10.97%
to/f64/4096 29.2 µs 26.3 µs +11.06%

Comparing DaniPopes:ban-bits-zero (3851eb8) with main (bff85c8)

Open in CodSpeed

@prestwich
Copy link
Copy Markdown
Member

i'm generally in favor, however, this is a 2.0 change. are we planning a 2.0 release and if so, what else do we want in?

@prestwich
Copy link
Copy Markdown
Member

related: #502

@DaniPopes
Copy link
Copy Markdown
Member Author

Gonna wait for this

@DaniPopes DaniPopes closed this May 8, 2026
@DaniPopes DaniPopes deleted the ban-bits-zero branch May 8, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants