Skip to content

feat: add ark-ff-06#584

Merged
prestwich merged 1 commit into
alloy-rs:mainfrom
Robert-MacWha:main
May 8, 2026
Merged

feat: add ark-ff-06#584
prestwich merged 1 commit into
alloy-rs:mainfrom
Robert-MacWha:main

Conversation

@Robert-MacWha
Copy link
Copy Markdown
Contributor

Motivation

Solves #583

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@Robert-MacWha Robert-MacWha requested a review from prestwich as a code owner May 7, 2026 23:36
@Robert-MacWha
Copy link
Copy Markdown
Contributor Author

Ran tests locally and it seems to be working. If there's any issues in the CI I can fix them

@Robert-MacWha Robert-MacWha mentioned this pull request May 7, 2026
@prestwich
Copy link
Copy Markdown
Member

Thanks, I will review :)

@prestwich prestwich linked an issue May 8, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Member

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm — pure clone of ark_ff_05.rs with 05→06 version bumps

@prestwich prestwich requested a review from DaniPopes May 8, 2026 07:36
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 8, 2026

Merging this PR will improve performance by 11.41%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
✅ 383 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
most_significant_bits/4096/4096 28.9 µs 26.1 µs +10.87%
to/f32/4096 28.7 µs 25.7 µs +11.33%
to/f64/4096 28.8 µs 25.8 µs +11.41%

Comparing Robert-MacWha:main (3dc44f0) with main (836a44f)

Open in CodSpeed

@prestwich prestwich merged commit e17160d into alloy-rs:main May 8, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support ark-ff-06

3 participants