Skip to content

Added parametrized dynamic links to use like @allure.link('{link}') or @allure.testcase('{testcase_link}') #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions allure-pytest/examples/link/link.rst
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,14 @@ Links
... def test_custom_link():
... pass

>>> import pytest
>>> @allure.link("{link}")
>>> @pytest.mark.parametrize("test, link", [(True, 'link/666'), (False, 'link/777')])
>>> def test_parametrize_link(test, link):
... assert test

>>> @allure.issue("{issue}")
>>> @allure.testcase("{testcase}")
>>> @pytest.mark.parametrize("test, issue, testcase", [(True, 'issues/666', 'testcase/666'), (False, 'issues/777', 'testcase/777')])
>>> def test_parametrize_link_multiple(test, issue, testcase):
... assert test
3 changes: 2 additions & 1 deletion allure-pytest/src/listener.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ def pytest_runtest_teardown(self, item):
yield
uuid = self._cache.get(item.nodeid)
test_result = self.allure_logger.get_test(uuid)
params = item.callspec.params if hasattr(item, 'callspec') else {}
test_result.labels.extend([Label(name=name, value=value) for name, value in allure_labels(item)])
test_result.labels.extend([Label(name=LabelType.TAG, value=value) for value in pytest_markers(item)])
test_result.labels.extend([Label(name=name, value=value) for name, value in allure_suite_labels(item)])
Expand All @@ -118,7 +119,7 @@ def pytest_runtest_teardown(self, item):
test_result.labels.append(Label(name=LabelType.FRAMEWORK, value='pytest'))
test_result.labels.append(Label(name=LabelType.LANGUAGE, value=platform_label()))
test_result.labels.append(Label(name='package', value=allure_package(item)))
test_result.links.extend([Link(link_type, url, name) for link_type, url, name in allure_links(item)])
test_result.links.extend([Link(link_type, url, name) for link_type, url, name in allure_links(item, params)])

@pytest.hookimpl(hookwrapper=True)
def pytest_fixture_setup(self, fixturedef, request):
Expand Down
4 changes: 2 additions & 2 deletions allure-pytest/src/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ def allure_labels(item):
return labels


def allure_links(item):
def allure_links(item, parameters):
for mark in item.iter_markers(name=ALLURE_LINK_MARK):
yield (mark.kwargs["link_type"], mark.args[0], mark.kwargs["name"])
yield (mark.kwargs["link_type"], mark.args[0].format(**parameters), mark.kwargs["name"].format(**parameters))


def pytest_markers(item):
Expand Down
23 changes: 23 additions & 0 deletions allure-pytest/test/acceptance/link/link_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,26 @@ def test_custom_link(executed_docstring_path):
has_link("http://qameta.io", name="QAMETA", link_type="homepage")
)
)


def test_parametrize_link(executed_docstring_path):
testcases = [{'url': 'link/666'}, {'url': 'link/777'}]
for test in testcases:
assert_that(executed_docstring_path.allure_report,
has_test_case("test_parametrize_link",
has_link(test['url']),
)
)


def test_parametrize_link_multiple(executed_docstring_path):
testcases = [{'issue': 'issues/666', 'testcase': 'testcase/666'},
{'issue': 'issues/777', 'testcase': 'testcase/777'}]

for test in testcases:
assert_that(executed_docstring_path.allure_report,
has_test_case("test_parametrize_link_multiple",
has_issue_link(test['issue']),
has_test_case_link(test['testcase'])
)
)