fix: reject unbounded f64 raw transaction amounts#137
Conversation
storopoli
left a comment
There was a problem hiding this comment.
small NIT on the error message
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
CreateRawTransactionOutputserialized address amounts withNumber::from_f64(...).unwrap(). If a caller passed a nonfinite value such asNaN, serialization could panic.This returns a serialization error for nonfinite output amounts instead and adds regression coverage.